Now a couple of weeks ago I posted this: https://forums.dovetailgames.com/threads/failed-to-publish-file-on-steam-workshop.92961/ Having done further investigation I worked out that the reason this was happening was because of the screenshot. As a test I uploaded the scenario with a random screenshot from an older scenario I had and sure enough it worked. Later on I tried uploading a different scenario on a different route with a different, more recently taken screenshot and it failed to upload. Now, having tried with different screenshots from different dates it seems that every Trainsim screenshot taken on my laptop after about a month ago is faulty and doesn't allow me to upload to Steam Workshop, but every screenshot before that point does. Has something gone wrong with my laptop or is it something wrong with TS Classic?
The screenshots taken after a certain date are bigger and had a higher resolution, but there is a caveat. Even re-sizing them didn't work. I also changed the resolution on TS classic to what it originally was, and re-took the screenshots but they were also rejected.
It might be worth checking the format the laptop save them in - it should be .jpg - if they are not it could be the problem What size are the screenshots? I also found these threads which might help https://forum.keenswh.com/threads/workshop-thumbnail-size-limits-failure-to-upload.7403560/ https://steamcommunity.com/app/244850/discussions/0/4298194451994443571/
They are all .JPG and they are now all several hundred KB, the more recent ones after about 1 month ago were originally 1MB or more but I re-sized them and when that didn't work, I changed the resolution to match the older screenshots and re-took the ones from the newer scenarios. Nothing changed although now it gets to 83% of the way through the upload before failing.